-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zarith-freestanding.1.6 + zarith-xen.1.6 #10350
Conversation
73c574a
to
3c0bf97
Compare
❗ opam-lint warnings b34604f
✅ Installability check (7503 → 7509)
|
@hannesm Didn't you want to upgrade (Possibly I'm being too paranoid here, but I'm not 100% sure about any side-effects of the -fPIC change and don't have the bandwidth to test right now) |
@mato well, gmp.6.1.2 turns out to need more C symbols -- which also means modifications to ocaml-freestanding (already merged) and the ocaml-xen stuff. I did a full end-to-end test using ukvm and FreeBSD with the mirage-skeleton |
@hannesm I guess my point is that this changes the build of |
so, are there any opinions how to move forward here? travis passes fine! has anyone a clue why opam1 and opam2 behave differently in respect to solo5 and depext? |
/cc @avsm I'd be glad to get an opinion here - zarith-*.V has strict dependencies onto |
@hannesm @mato - we could enable pic on a minor version bump of the package (add "a" or something to the suffix to denote it rather than changing the existing package). Then version constraints will let zarith-freestanding pick up the pic versions, but also address @mato's concern about changing an existing library without a version bump. |
@avsm sounds like a good idea. I used |
CI failures indicate that ocamlfind is not available (502 - bad gateway)... |
I've cancelled the Travis build; we can restart it once findlib/ocamlfind is available again (#10383). |
…ith-pic) depend in zarith-{xen,freestanding}.1.6 on "> gmp-{xen,freestanding}.6.0.0"
I rebased upon current master, and travis is happy again! :) |
failures for debian unstable & testing are due to a fresh gcc, which are fixed upstream in solo5 (Solo5/solo5@48f8c4f) |
ping. CI seems to be happy, apart from the above mentioned problem with released solo5 and gcc7. |
I just ran a manual smoketest with Unfortunately there's not a lot we can easily do right now about the gcc7 failures, is that a problem for merging this? |
@mato thx! what we could do is to include a patch into opam-repository which removes |
@hannesm Well, "on the horizon" is more like "some time this month", so patching |
@hannesm Thanks. Nit: You should probably call those packages |
…h removing -Werror to unbreak build with gcc7
@hannesm Thanks, tested, LGTM! |
according to https://packages.debian.org/search?searchon=contents&keywords=asm%2Fmsr-index.h&mode=exactfilename&suite=unstable&arch=any Debian unstable/testing/experimental provides the file |
It looks like that header is not shipped in Debian (anymore)?
|
@cfcs Will keep looking to see if I can find a solution. Up to the opam-repository maintainers to decide if this can go in with the new distros (Debian testing, unstable, Fedora 25) failing. |
@hannesm After some discussion, it's unclear what the situation with |
…er shipped with linux-libc-dev (by @mato)
this is finally green again and ready for merge. to sum up the changes:
I didn't intended to go this deep down here, but I'm glad that the resulting repository is installable on a wide variety of Linux distributions. The patches for If someone would be so kind to merge this PR, I'd be glad (and can finally have my binaries where the stack is non-executable). Thanks! |
Many thanks for leading this PR to its conclusion :-) |
this adds the two above mentioned packages. in order to build zarith-freestanding (at least on FreeBSD), gmp-freestanding and gmp-xen needs to pass
--with-pic
during configuration phase (which enables-fPIC
).//cc @mato